zip files created with an own cloud service are ingested as is - Githubissues

IQSS / dataverse

Open source research data repository software

http://dataverse.org

Other

878 stars 487 forks source link

zip files created with an own cloud service are ingested as is #10898

Open jo-pol opened 5 days ago

jo-pol commented 5 days ago

What steps does it take to reproduce the issue?

download multiple files from an own cloud service for example greetings.zip and shapes.zip (the individual shape file contain garbage, it is about rezipping)
upload the zip into a dataset
the zip is ingested as is with a warning message
unzip an rezip the files before upload and the result is as expected

Which version of Dataverse are you using?

It happens both on 6.2 and 6.4

Any related open or closed issues to this bug report? Not sure but replacing ZipInputStream with ZipFile might influence the following issues https://github.com/IQSS/dataverse/issues/7507 https://github.com/IQSS/dataverse/issues/7352 https://github.com/IQSS/dataverse/issues/2482 https://github.com/IQSS/dataverse/issues/10591

Screenshots:

Current result on the left, on the right expected result with the files attached above after saving the changes

zip-as-is expected:

Are you thinking about creating a pull request for this issue? yes

qqmyers commented 5 days ago

FWIW: I don't know the details of what owncloud is doing, but in discussion with @jo-pol, it sounds like the current code gives an "only DEFLATED entries can have EXT descriptor" error, presumably because owncloud is using an option for zip that is inconsistent with the ZipInputStream processing.