IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
882 stars 494 forks source link

Published datasets should contain files #10994

Open stevenwinship opened 3 weeks ago

stevenwinship commented 3 weeks ago

What this PR does / why we need it: The existing publishing model in HDV allows the publishing of datasets without files. This lends to the curation team contacting depositors about uploading files via support and often to deleting "empty" datasets.

To decrease the support contact and dataset deletions, change the publishing model to require all deposits contain at least one file before publishing can happen.

Which issue(s) this PR closes:https://github.com/IQSS/dataverse/issues/10981

Special notes for your reviewer:

Suggestions on how to test this: See the added IT test

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: Included

Additional documentation:

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10981-published-datasets-should-contain-files
ghcr.io/gdcc/configbaker:10981-published-datasets-should-contain-files

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

coveralls commented 2 weeks ago

Coverage Status

coverage: 21.854% (-0.002%) from 21.856% when pulling 8cfa93873acd91310bb9609423c08cf666325b00 on 10981-published-datasets-should-contain-files into b28812b42bb2babd6d4c2328fad791fc41d9183e on develop.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10981-published-datasets-should-contain-files
ghcr.io/gdcc/configbaker:10981-published-datasets-should-contain-files

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 21 hours ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10981-published-datasets-should-contain-files
ghcr.io/gdcc/configbaker:10981-published-datasets-should-contain-files

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 21 hours ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10981-published-datasets-should-contain-files
ghcr.io/gdcc/configbaker:10981-published-datasets-should-contain-files

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 20 hours ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10981-published-datasets-should-contain-files
ghcr.io/gdcc/configbaker:10981-published-datasets-should-contain-files

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 20 hours ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10981-published-datasets-should-contain-files
ghcr.io/gdcc/configbaker:10981-published-datasets-should-contain-files

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

sbarbosadataverse commented 20 hours ago

I have one comment @stevenwinship can we say "published datasets should contain at least one 'data' file? To help users understand we want data and not just a pdf of am article?

stevenwinship commented 18 hours ago

Changed the message

image

github-actions[bot] commented 17 hours ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10981-published-datasets-should-contain-files
ghcr.io/gdcc/configbaker:10981-published-datasets-should-contain-files

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.