IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
882 stars 494 forks source link

github actions from v3 to v4 #10997

Closed stevenwinship closed 2 days ago

stevenwinship commented 2 weeks ago

What this PR does / why we need it: Starting November 30, 2024, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact or actions/download-artifact.

Which issue(s) this PR closes:https://github.com/IQSS/dataverse/issues/10993

Special notes for your reviewer: I chose to update all the V3 to V4 actions in the yml files. Only the upload and download were required but I felt it's better to not mix/load multiple library versions if possible. Due to a bug in download-artifact@V4 the version was bumped to 4.1.7 to include the fix As mentioned in an issue that there was a bug in download V4 that was fixed in 4.1.7 https://github.com/actions/upload-artifact/issues/478 Update: v4 now gets the latest so download-artifact can now use v4 to get the fix in 4.1.7 (latest is v4.1.8 as of this PR)

Suggestions on how to test this: I've made temporary changes to various files to force most of the actions to run. Obviously any release specific actions were not run. I think the best way to test it is to merge it and monitor the build system.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 2 weeks ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10993-stop-using-action-v3
ghcr.io/gdcc/configbaker:10993-stop-using-action-v3

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

coveralls commented 2 weeks ago

Coverage Status

coverage: 21.856%. remained the same when pulling 69112461caac6d2a7d6dd4bdf7b30159b9d59b01 on 10993-stop-using-action-v3 into b28812b42bb2babd6d4c2328fad791fc41d9183e on develop.

pdurbin commented 1 week ago

@stevenwinship this pull request looks fine if we want to do the same thing as last time... merge it, see if anything breaks, and revert it if necessary.

I see 15 commits. Did you do some testing? If so, can you please write a little about it?

"Suggestions on how to test this" is empty. Is this because we plan to just merge it and see if anything breaks?

stevenwinship commented 1 week ago

The reason for so many commits was indeed testing. I wanted to test with updating all yml files to V4 but ran into some issues so I ended up limiting the changes to the 2 files that were failing. I also tested with java changes and doc changes to force all the tests/actions to run. As for "How To Test", yes merging and monitoring would be the best way to verify it beyond what I've already done.

pdurbin commented 1 week ago

Also, I assumed "v4" meant "the latest v4 but it doesn't. See https://github.com/orgs/community/discussions/25248

That is, v4 means https://github.com/actions/download-artifact/releases/tag/v4

v4 does not meant the latest, which as of this writing, is https://github.com/actions/download-artifact/releases/tag/v4.1.8

ofahimIQSS commented 2 days ago

Merging PR - monitoring github actions

pdurbin commented 1 day ago

https://github.com/IQSS/dataverse/actions/workflows/deploy_beta_testing.yml is failing.