Closed stevenwinship closed 2 weeks ago
@stevenwinship - I see the JsonParserTest.parseDataverseDTO test failure - can you update from develop to get the fix for it (I assume that's the problem).
@stevenwinship I'm trying to push the PR to Internal and received a failure in jenkins: [ERROR] Failures: [ERROR] JsonParserTest.parseDataverseDTO:286 expected: pi@example.edu,student@example.edu but was: pi@example.edu
Could you please update your PR with the latest from Dev. Thanks!
Edit: Just saw the update on the PR - will retest with latest build
@stevenwinship Came across an observation while testing the fix in Internal.
Reproduction Steps:
Note: I uploaded 1 csv file on Nov 4th, 2024 and published the dataset. I pushed the fix to internal then I added 9 more files to the same dataset with Deposited date: Nov. 6, 2024.
My guess is that internal has Order By Folder turned on. With that, the sorting (newest/oldest/alphabetical, etc.) is done within each folder.
Thanks @qqmyers that did the trick. Merging PR Testing of 11000.docx
https://github.com/user-attachments/assets/6fc180cc-42f8-42c4-be04-77ea1fdfc3b0
What this PR does / why we need it: Sort order in UI on dataset file listing is backwards for Newest and Oldest
Which issue(s) this PR closes:https://github.com/IQSS/dataverse/issues/10742
Special notes for your reviewer: fully tested the comparator and determined it was just a UI issue
Suggestions on how to test this: Test using UI On a dataset file listing, click "Sort -> Newest" The resulting order should be newest first.
On a dataset file listing, click "Sort -> Oldest" The resulting order should be oldest first.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: