IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
882 stars 494 forks source link

Quirk in overview display when using external controlled variables #11005

Open bjosel opened 2 weeks ago

bjosel commented 2 weeks ago

What steps does it take to reproduce the issue? Add some JS-script and configure ":CVocConf" in order to select entries from external vocabularies or id-providers

Which version of Dataverse are you using? 6.4

Screenshots: Author names and project title are shown repeatedly ohnePatch_alteOrcid_mitFooter

If we apply a small patch author names and project title are displayed correctly mitPatch_altesOrcid_mitFooter

Are you thinking about creating a pull request for this issue? Yes, we can create a PR. Our patch would be the following:

Screenshot from 2024-11-07 15-58-42

This effectively changes the logic of the decision if data is rendered from NOT(ITEM1 AND ITEM2) to NOT(ITEM1 OR ITEM2). All test so far didn't expose any side effects of the patch

qqmyers commented 2 weeks ago

Thanks for the report and possible fix. FWIW: I think our most recent testing has been done using authorsOrcidAndRor.json, which works as can be seen for doi:10.70122/FK2/NEQHTE. Can you make sure your fix works for that case as well?

bjosel commented 2 weeks ago

Yes, we tested with the latest authorsOrcidAndRor.json, too. It works with our patch, see the screenshot mitPatch_neuesOrcid_mitFooter

DS-INRAE commented 3 days ago

Great! Would you be willing to make the PR to contribute your patch then ? :)

ffritze commented 3 days ago

A pull-request has been created: https://github.com/IQSS/dataverse/pull/11034