IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
882 stars 494 forks source link

validate guestbook email field #11022

Closed stevenwinship closed 2 days ago

stevenwinship commented 6 days ago

What this PR does / why we need it: Guestbook email field is not validated.

Which issue(s) this PR closes: https://github.com/IQSS/dataverse/issues/10661

Special notes for your reviewer:

Suggestions on how to test this: Test existing code and new code entering empty. valid, and invalid email addresses.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: image

Is there a release notes update needed for this change?:

Additional documentation:

github-actions[bot] commented 6 days ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10661-guestbook-email-field-not-validated
ghcr.io/gdcc/configbaker:10661-guestbook-email-field-not-validated

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 6 days ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10661-guestbook-email-field-not-validated
ghcr.io/gdcc/configbaker:10661-guestbook-email-field-not-validated

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 6 days ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10661-guestbook-email-field-not-validated
ghcr.io/gdcc/configbaker:10661-guestbook-email-field-not-validated

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 6 days ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10661-guestbook-email-field-not-validated
ghcr.io/gdcc/configbaker:10661-guestbook-email-field-not-validated

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

stevenwinship commented 6 days ago

Moving back to in progress. There is an issue caused by this fix that does affect an API

Caused by: jakarta.validation.ConstraintViolationException: One or more Bean Validation constraints were violated while executing Automatic Bean Validation on callback event: prePersist for class: edu.harvard.iq.dataverse.GuestbookResponse. Please refer to the embedded constraint violations for details.

github-actions[bot] commented 6 days ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10661-guestbook-email-field-not-validated
ghcr.io/gdcc/configbaker:10661-guestbook-email-field-not-validated

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

ofahimIQSS commented 2 days ago

Testing passed - Merging PR Testing of 10661.docx