search

IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
876 stars 484 forks source link

Dataset Page - Includes + Multiple Pages #1665

Closed mheppler closed 9 years ago

mheppler commented 9 years ago

Coming in at over 2300 lines of code, the dataset.xhtml file should be split up into includes, and multiple pages (ie: new page for Edit Dataset and Upload + Edit Files, rather than editMode views).

mheppler commented 9 years ago

This also would allow for using PrettyFaces URLs for datasets.

From @scolapasta in an email dated 12/10/14:

we want global ids for the dataset URL, both for pretty face (which like we said in the meeting on Monday had an issue with the file upload)

Also see, related dataverse Theme + Widget file upload + PrettyFaces ticket #1126.

mheppler commented 9 years ago

Development for this high-end task has been started. The initial commit 87b5c659282d3727f418eab8dde521be9cdd2609 from @landreev is just the beginning of the work needed to break out the edit and upload workflows for dataset files.

The metadata edit view might be held off for a later release. A new issue (#2486) has been created for the PrettyFaces URL formatting.

landreev commented 9 years ago

@pdurbin also did some work related to this task, by isolating some of the files display functionality in its own xhtml include fragment. The next step now is to modify the dataset.xhtml page, to redirect to my editfilespage.xhtml when users click the "edit files" button (for the files selected via checkboxes). It looks like @sekmiller is working on it. Steve, you mind if I give you this ticket for now?

sekmiller commented 9 years ago

Leonid,

I’m also going to have to do some work on your edit data files page (editDatafiles.xhtml) since it refers to some terms of use and access before they were split out from datasetVersion. Are you out of that for the time being?

Thanks!

On Sep 1, 2015, at 3:59 PM, landreev notifications@github.com<mailto:notifications@github.com> wrote:

@pdurbinhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pdurbin&d=BQMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=d7bbsLIcERTG2Qe_gE_iKH1z80JxaTHhJpRXaS4mxwM&m=TnTMaRk7w3lQI_hyPJEbRtAKSelMZfFLydK9bhD7gfg&s=DVoYa18zqew39_at1HlcDi52oMU9Pt5dakr5XFwql7A&e= also did some work related to this task, by isolating some of the files display functionality in its own xhtml include fragment. The next step now is to modify the dataset.xhtml page, to redirect to my editfilespage.xhtml when users click the "edit files" button (for the files selected via checkboxes). It looks like @sekmillerhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sekmiller&d=BQMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=d7bbsLIcERTG2Qe_gE_iKH1z80JxaTHhJpRXaS4mxwM&m=TnTMaRk7w3lQI_hyPJEbRtAKSelMZfFLydK9bhD7gfg&s=l-meI6TCj65iDfXK02Yz8B5SxptTADV7Qf-AaisdgYc&e= is working on it. Steve, you mind if I give you this ticket for now?

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_IQSS_dataverse_issues_1665-23issuecomment-2D136842225&d=BQMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=d7bbsLIcERTG2Qe_gE_iKH1z80JxaTHhJpRXaS4mxwM&m=TnTMaRk7w3lQI_hyPJEbRtAKSelMZfFLydK9bhD7gfg&s=yFKYUeUv5KImbmsiHp3lUFQdPgfl18sNg8Gcgwz6cnA&e=.

landreev commented 9 years ago

Steve,

Sorry - somehow missed your last question. I'm still working on the editDatafiles.xhtml; but feel free to make changes to it - I don't mind merging my changes if I need to. For now I just changed workingVersion.termsOfAccess to workingVersion.termsOfUseAndAccess.termsOfAccess in a couple of places ther, after you committed your Terms of Use changes.

(also, there's a chance I'll be completely done with that page over the weekend)

sekmiller commented 9 years ago

Added bulk update of files (restrict/unrestrict, tags, delete)

eaquigley commented 9 years ago

@sekmiller looking at this ticket more in depth it does not seem to be the right one to send to @mheppler. I've added the previous comments here to #2503. I think this ticket needs to be moved to QA and a ticket for the pretty faces URL has already been created #2486 Passing to @kcondon

kcondon commented 9 years ago

OK, discussed with Mike and Liz about what this ticket meant in terms of scope of testing since there are other UI related tickets. This ticket will cover the workflows identified by Liz' doc:

https://docs.google.com/document/d/1wyJe2J1RNg-zs24YTGHqOwd1YyhwqjRRMBgtw6mWMOc/edit?usp=sharing

These have been tested so I will close the ticket. Remaining testing includes: Verifying UI against mockups, testing incomplete work (download selected), and individual issues that were reported.

Closing.