IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
878 stars 490 forks source link

Clarify docs that Shibboleth/SAML is supported by OpenID Connect (OIDC) #6701

Closed pdurbin closed 2 months ago

pdurbin commented 4 years ago

http://guides.dataverse.org/en/4.19/installation/shibboleth.html doesn't mention OpenID Connect (OIDC) but from a quick test with @poikilotherm at https://data-beta.fz-juelich.de I seem to be able to log in with my HarvardKey. As the screenshots below indicate, now I just need to wait for someone to approve my account.

Screen Shot 2020-02-27 at 8 17 49 AM Screen Shot 2020-02-27 at 8 18 02 AM Screen Shot 2020-02-27 at 8 18 43 AM Screen Shot 2020-02-27 at 8 19 13 AM Screen Shot 2020-02-27 at 8 19 25 AM Screen Shot 2020-02-27 at 8 20 57 AM Screen Shot 2020-02-27 at 8 21 57 AM
pdurbin commented 4 years ago

I got an email and clicked a link. "Sign Up completed."

Screen Shot 2020-02-27 at 8 30 49 AM Screen Shot 2020-02-27 at 8 31 02 AM

I'm not sure what to do now... I guess I should return to the other browser window that looks like this:

Screen Shot 2020-02-27 at 8 21 57 AM
apw1388 commented 4 years ago

Sadly you have no redirect to the services after the registration. You need to restart the login flow from the services.

pdurbin commented 4 years ago

@apw1388 thanks. At http://irclog.iq.harvard.edu/dataverse/2020-02-27#i_119565 @poikilotherm suggested "Just close that popup/overlay and click on the Harvard IdP again" and I just did. This is what I got:

Screen Shot 2020-02-27 at 8 21 57 AM Screen Shot 2020-02-27 at 8 35 48 AM Screen Shot 2020-02-27 at 8 36 02 AM Screen Shot 2020-02-27 at 8 36 22 AM

Is this all looking ok? Should I click "Confirm"?

poikilotherm commented 4 years ago

Perfectly fine! :smile: Yeah, the UX still needs tuning...

And beware: the Dataverse side is not perfectly ready for this yet. That's why I opened that huge bunch of issues, like #6679, #6690, #6694 etc. I will need #6694 also for my ideas about group mapping and custom attributes back in #5974

pdurbin commented 4 years ago

@poikilotherm ok, I clicked "Confirm" (after first clicking the arrow to see more details) and this is what I got:

Screen Shot 2020-02-27 at 8 42 25 AM Screen Shot 2020-02-27 at 8 42 37 AM Screen Shot 2020-02-27 at 8 42 56 AM

I clicked "Central Library - Research Data Management" and got a spinner and then the text moved.

Screen Shot 2020-02-27 at 8 45 46 AM

I made the window taller:

Screen Shot 2020-02-27 at 8 46 40 AM

Not sure what's going on. Nothing in the Javascript console log.

pdurbin commented 4 years ago

@poikilotherm just asked "Could you just re-initiate the login?" and I did and it worked! ๐ŸŽ‰

Screen Shot 2020-02-27 at 8 49 50 AM Screen Shot 2020-02-27 at 8 49 55 AM Screen Shot 2020-02-27 at 8 50 06 AM Screen Shot 2020-02-27 at 8 50 17 AM Screen Shot 2020-02-27 at 8 50 31 AM Screen Shot 2020-02-27 at 8 51 45 AM

Good job @poikilotherm and @apw1388 !!!

pdurbin commented 4 years ago

Along the way a couple emails came through:

Screen Shot 2020-02-27 at 8 57 17 AM Screen Shot 2020-02-27 at 8 58 11 AM

@poikilotherm if you host your own guides and configure http://guides.dataverse.org/en/4.19/installation/config.html#guidesbaseurl you could mention https://login.helmholtz-data-federation.de in your custom guides (the guides link is in the "Jรผlich DATA - Beta Training Facility: Your account has been created" email) and explain in your custom guide that MULTIPLE LOGIN TO THE SAME ACCOUNT (for me HarvardKey, ORCID, GitHub) IS SUPPORTED! The dream of #3487 is alive!!! ๐ŸŽ‰ ๐ŸŽ‰ ๐ŸŽ‰ I need to lie down. ๐Ÿ›

bencomp commented 1 year ago

I think this issue is about adding a link from the Shibboleth installation page to the OIDC page, but I'm not sure. Could you elaborate, @pdurbin? I don't understand this issue's title: "Shibboleth/SAML is supported by OpenID Connect (OIDC)".

pdurbin commented 1 year ago

@bencomp right, at minimum I was thinking we could add a section at the end of doc/sphinx-guides/source/installation/shibboleth.rst that links to the OIDC docs. Maybe "Other Ways to Support Shibboleth/SAML" could be the title of the section.

The OIDC docs are here: doc/sphinx-guides/source/installation/oidc.rst

bencomp commented 1 year ago

I think what you mean is "Other ways to support single sign-on" as the section title? Otherwise this is clear.

pdurbin commented 1 year ago

Sure, that's fine. Here's a preview of how the OIDC page will look in the next release: https://preview.guides.gdcc.io/en/develop/installation/oidc.html

Please note that SAML is mentioned a couple times. It's a way not to run Shibboleth:

As a use case:

cmbz commented 2 months ago

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

pdurbin commented 2 months ago

It's fine that this issue was closed. Auth will be changing a lot in the future. I recommend reading our doc on it: https://docs.google.com/document/d/1624KuPj4zp_TQzWivqaNY3YUCzibwFib8tZUz_IshTo/edit?usp=sharing