IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
876 stars 484 forks source link

Delete Dataset: Deleting a draft of a published dataset does not removed deleted draft from index. #679

Closed eaquigley closed 10 years ago

eaquigley commented 10 years ago

Author Name: Kevin Condon (@kcondon) Original Redmine Issue: 4129, https://redmine.hmdc.harvard.edu/issues/4129 Original Date: 2014-06-18 Original Assignee: Kevin Condon


Tested on 6/18

Deleting a draft of a published dataset does not removed deleted draft from index.

eaquigley commented 10 years ago

Original Redmine Comment Author Name: Philip Durbin (@pdurbin) Original Date: 2014-06-18T15:16:41Z


I spoke with Stephen about this. The index method is called last, which is great, but for some reason the dataset that's passed in still has the version that was deleted:

rationale:
version found with database id 7
- title: Roasting at Home 6
- semanticVersion-STATE: DRAFT-DRAFT
- isWorkingCopy: true
- isReleased: false
- files: 0 []
version found with database id 2
- title: Roasting at Home
- semanticVersion-STATE: 1.0-RELEASED
- isWorkingCopy: false
- isReleased: true
- files: 0 []

I think some extra merging or something needs to happen. Stephen mentioned needing to do some manual deletion or something in other parts of the code. Sorry, I'm fuzzy on the details.

eaquigley commented 10 years ago

Original Redmine Comment Author Name: Steve Kraffmiller (@sekmiller) Original Date: 2014-06-18T15:44:31Z


removed deleted version form ds obj before reindexing.

Fix in for 1140 6/18.

eaquigley commented 10 years ago

Original Redmine Comment Author Name: Kevin Condon (@kcondon) Original Date: 2014-06-18T17:39:33Z


Tested on 6/18 works closing ticket