IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
878 stars 490 forks source link

Review and improve metadata tooltips, field labels and watermarks #8127

Closed TaniaSchlatter closed 2 years ago

TaniaSchlatter commented 3 years ago

This issue is to outline and track the effort to improve tooltips, field labels and watermarks related to metadata blocks. Clear and consistent tip text, labels and watermarks should help depositors curate their datasets and enter data accurately, leading to more and more consistent metadata.

Goals:

Scope/definition of done: Review metadata tooltip text, field labels and watermarks for consistency and clarity: citation block, social sciences block, journals, geospatial, astrophysics

jggautier commented 3 years ago

We're recommending removing some tooltips. I tested if removing certain tooltips from the UI would be as easy as just removing the text in the description columns of a metadatablock's TSV file, like in the citation.tsv file:

Screen Shot 2021-10-19 at 2 01 23 PM

To test this, I created a fork, edited the citation.tsv file to remove some text in the description column that's used for the tooltips, and spun up the fork in an AWS instance. The tooltips I had tried to remove were still there, using the text that's in the latest version of the citation.tsv file.

So I'm writing this to say that we might want to get a sense of how much development work would be needed to make sure that the tooltips we determine should be removed can be removed.

djbrooke commented 3 years ago

@jggautier feel free to pop in #dv-tech if you want to talk through anything from the technical side.

djbrooke commented 2 years ago

Thanks @TaniaSchlatter @scolapasta @jggautier for discussing earlier. The above checklist remains accurate.

jggautier commented 2 years ago

I think most of the edits to the titles, tooltips and watermarks of fields in the citation metadatablock can be made by editing and reloading the citation.tsv file and citation.properties file. I've been making those changes in a branch at https://github.com/IQSS/dataverse/tree/8127-citation-field-improvements and I'm able to update that branch with those types of changes.

The changes that we agree should be made for this GitHub issue but can't be made by editing and reloading the citation.tsv file and citation.properties file are:

Can those three things be changed easily?

The "working rules" to guide grammar and style/consistency are shaping up, too. I think they should be made publicly available, but when and how are open questions.

There are other changes we felt would be improvements but that we decided not to make for this first round of improvements because they would involve a level of design and development work that would hold up the majority of the other improvements. We'll be opening other GitHub issues about those.

scolapasta commented 2 years ago

@jggautier I would expect those changes to just have to be made to the bundle.

jggautier commented 2 years ago

Ah okay, thanks. I think I see where in the Bundle.properties file (https://github.com/IQSS/dataverse/blob/develop/src/main/java/propertyFiles/Bundle.properties). I'll give it a try.

jggautier commented 2 years ago

That worked, thanks!

jggautier commented 2 years ago

Tooltips aren't being removed as part of these changes, so the PR attached to this issue doesn't remove any tooltips.

jggautier commented 2 years ago

To share the Style Guide, @TaniaSchlatter and I thought it would be best to include a link to the Google Doc in the Admin Guide's Metadata Customization page, maybe in a "Style Guide" section after the "Introduction" section. After the guide's been tested more (i.e. we get more feedback as it's reviewed and used more often to apply the guidelines to the application's other metadata field names, tooltips and watermarks), we could consider moving the text into the actual guides.

So the last to do for this issue is for me to prepare the style guide to be able to share more widely and add it the Metadata Customization page:

jggautier commented 2 years ago

We've decided to add the guidelines to the Style Guide, in a new page called "Text" for style guidelines related to text. The page, created in the PR associated with this issue, is called "Text" and will include a link to the Google Doc where we're keeping the metadata text guidelines for now (since we expect frequent changes to it).

In the "Tips from the Dataverse Community" section of the Metadata Customization page, I mention and link to the Style Guide and its "Text" page.

I hope by the end of this week to have the Google Doc organized enough so that the link to it can be included in the Text page and that should be the last to-do for this issue.

jggautier commented 2 years ago

The Style Guide "Text" page is updated. Moving the PR to the review column.

mreekie commented 2 years ago

Sprint:

pdurbin commented 2 years ago

PR #8592 was just merged so as discussed I just put this issue in "Next Sprint". Also as discussed, we need a new PR.

jggautier commented 2 years ago

I just submitted the changes in a new PR.

mreekie commented 2 years ago

Prio: