IQTLabs / hypothesis-bio

Hypothesis extension for computational biology
https://lab41.github.io/hypothesis-bio
Apache License 2.0
15 stars 2 forks source link

Can we drop Blast6 for hypothesis-csv? #72

Closed Benjamin-Lee closed 4 years ago

Benjamin-Lee commented 4 years ago

It seems that hypothesis-csv already has pretty good support for generating tab-delimited files. Would it make sense to drop our blast6 implementation and add a section in the docs referring users to hypothesis-csv (maybe with an example)?

vaastav commented 4 years ago

Hmm, maybe. The thing is we have specific rules for generating specific columns but I think they can be supported via hypothesis-csv....

Also there are 44 different columns in Blast6 which is something a user wouldn't care to write generators for so it might screw up with the usability.

What we could do instead is show an example of how our generators for columns can be used with hypothesis-csv. I think that's the right thing to do here.

Benjamin-Lee commented 4 years ago

Ok that sounds good to me