Split based on AST context

IQTLabs / textlint-rule-one-sentence-per-line

A fixable textlint rule to add a line break after each sentence

Apache License 2.0

1 stars 3 forks source link

Split based on AST context #8

Closed kimburgess closed 3 years ago

kimburgess commented 3 years ago

Resolves #3 and #7.

Perform splits based on AST context, rather than raw paragraph string.

Note the current state of this PR does cause a regression for link titles and emphasis blocks. These are not detected.

Benjamin-Lee commented 3 years ago

I am fine with these regressions for now. Link titles on multiple lines are quite uncommon and long em blocks are a worthwhile sacrifice for closing #3 and #7. Thanks for the contribution!

kimburgess commented 3 years ago

Oh excellent. I had forgotten this PR has dangling and still tracking this branch. Those fresh commits are hopefully useful too though!

Benjamin-Lee commented 3 years ago

I invited you as a maintainer on the project since your knowledge of text lint is clearly much better than mine. Welcome!

kimburgess commented 3 years ago

Thank you, although I will have to decline as I have quite a few other projects that need tending to.

I am happy to continue as a contributor and will submit anything commonly useful back this way to prevent fragmentation.