search

IQVIA-ML / LightGBM.jl

Julia FFI interface to Microsoft's LightGBM package
Other
93 stars 10 forks source link

Consider using BinaryBuilder and BInaryProvider #112

Closed rofinn closed 3 months ago

rofinn commented 3 years ago

The current deps/build.jl script doesn't really work for me as it assumes I already have the lib_lightgbm.dylib dependencies already installed. Since Libdl.find_library doesn't provide any details on why the file doesn't work, you need to call dlopen on the downloaded file and install the system dependencies. BinaryBuilder provides a mechanism for specifying these dependencies and BinaryProvider provides a standardized interface for installing these dependencies on various platforms.

yalwan-sage commented 3 years ago

Hi @rofinn the only dependency is libomp -- did you have a trouble obtaining this?

rofinn commented 3 years ago

No, I can install it with brew on my local system. It’d be nice if we didn’t need to have it as a separate setup process though.

rofinn commented 3 years ago

If I find some time over the next week or two, I'll make a PR with that change.

yaxxie commented 3 years ago

See also: https://github.com/IQVIA-ML/LightGBM.jl/issues/37#issuecomment-613326087

A PR would be well received -- when doing so, it would be good to consider how to make this opt out.

kainkad commented 3 months ago

Hi @rofinn just to let you know I'm closing this issue as the LightGBM version >=v0.7.0 is now using BinaryBuilder so you shouldn't need to install any dependencies locally. BinaryProvider repo has been archived.