search

IQVIA-ML / LightGBM.jl

Julia FFI interface to Microsoft's LightGBM package
Other
93 stars 10 forks source link

Fix failing tests #126

Closed FatemehTahavori closed 2 years ago

FatemehTahavori commented 2 years ago

at the moment master is failing. This MR fixing those tests.

yaxxie commented 2 years ago

I'm not comfortable with adding compat just to make tests pass (which otherwise pass). If theres a problem within a specific docker image or environment, and its just to do with tests, considering ignoring the LGBM tests or configuring the environment properly.

yalwan-sage commented 2 years ago

The reason why pre-1.2 fails is because the test/Project.toml file is only applicable to later versions of Pkg distributed with 1.2 and above. To fix this, add to [Extras] section of Project.toml the same and add "Compat" to the test entry

The comment above was because I thought Compat.jl was being added to the main project, not as a test dependency.

You should explain what the issue is that you're trying fix, however, as theres no reproducing case within the tests themselves.

FatemehTahavori commented 2 years ago

The reason why I added this MR was to fix these tests. For me locally these tests are failing. I don't understand why these tests are passing in CI tests not locally. I will close this MR to first reproduce this issue

yalwan-sage commented 2 years ago

Which platform? If its mac m1 its likely to be to do with mixed architecture libs and your local julia installation being of a different architecture to the standard libs. If you're using intel julia, you could try getting intel python (libpython comes with python -- using the rosetta brew install will probably work) and making sure it is in the system linker path.