Don't try find_library tests if the system doesn't satisfy the assumptions

IQVIA-ML / LightGBM.jl

Julia FFI interface to Microsoft's LightGBM package

Other

93 stars 10 forks source link

Don't try find_library tests if the system doesn't satisfy the assumptions #128

Closed yaxxie closed 1 year ago

yaxxie commented 2 years ago

Recent M1 (cross architecture libs) issues and a weird docker image highlight a few circumstances where the assumed-to-be-present libs for the find_library tests aren't always present (in the expected forms, i.e. libname.system_extension)

To stop this test from failing and causing issues with users, if no such lib is found, the system is declared "broken" and these tests will subsequently be skipped as "broken", which doesn't cause alarming test failure messages.

yaxxie commented 2 years ago

@danielsoutar I've reverted these tests to the basic form. Now it will detect if its a broken system and just show these tests as "broken", which won't cause alarming failures. In addition, I refactored it to run setup only once, and removed a redundant test that wasn't checking anything new.