MLJTuning PR 75 (API Changes)

IQVIA-ML / TreeParzen.jl

TreeParzen.jl, a pure Julia hyperparameter optimiser with MLJ integration

Other

35 stars 5 forks source link

MLJTuning PR 75 (API Changes) #46

Closed yalwan-iqvia closed 3 years ago

yalwan-iqvia commented 4 years ago

Thank you for your contribution. You're a :star: already!

Draft PR from @ablaom for upcoming MLJTuning API changes (opened by @yalwan-iqvia)

Checklist

[x] Your code builds clean without any errors or warnings
[x] Unit tests have been added for core changes
[x] julia --project -e 'using Pkg; Pkg.test()' has been run locally and passes
[ ] Documentation has been updated with corresponding changes (if applicable)

ablaom commented 4 years ago

Requires:

[x] https://github.com/alan-turing-institute/MLJTuning.jl/pull/75

ablaom commented 4 years ago

@yalwan-iqvia I'm all done if you're happy with my responses.

yalwan-iqvia commented 4 years ago

@iqml as I have "opened" this PR, github wouldn't allow me to approve -- could you approve?

yalwan-iqvia commented 4 years ago

@ablaom Thanks for taking care of this and quickly at that. I hope you didn't find this piece of work too much trouble! I think we have no upcoming planned features for now for this project as well, so it would warrant an immediate release of TreeParzen 0.2 (could you add that into Project.toml?)

yalwan-iqvia commented 3 years ago

Thanks for this Anthony! I'll merge now and update documentation before I do a final release