Closed irving-muller closed 2 years ago
@irving-muller thanks for raising the issue. I'm looking into this as there seems to be a problem with dependencies. In the meantime you can ] add TreeParzen@v0.2.4
which compiles with no errors.
Once the issue with dependencies is sorted I'll let you know.
I had looked into this and it seems like this compilation issue is only for Julia 1.6+ version and seems to be failing on ScientificTypes, MLJBase which are used in TreeParzen for the MLJ API and tests. TreeParzen does install and otherwise works with Julia 1.6+ but it also should get these packages. To compare I have tested with Julia 1.5+ and it works without any compilation errors. It seems to be related to the changes made since updating dependencies for the 1.6 CI matrix. Below are the outputs for reference: For Julia 1.5+:
and for Julia 1.6+:
@ablaom I wonder if you could may be have some suggestions on what's best doing? I will look into this further but just comparing the versions this seems to only be affecting adding the package on Julia v1.6 and fails on compiling ScientificTypes and MLJBase. TreeParzen works otherwise on either Julia version.
@irving-muller Thanks for reporting @kd-iqvia Thanks for the further investigation
I have an idea what the problem is, and it is indeed on the ScientificTypes end.
ERROR: LoadError: LoadError: UndefVarError: ArrayLikeVariate not defined
UnivariateLikeVariate
is referenced in latest version of ScientificTypes. This type is from Distributions, but not defined until 0.25.1 (even thought breaking!) Unfortunately, the compat entry for Distributions in that version of ScientificTypes is 0.25.
So let's see if this helps:
I just noticed that 2 days ago MLJBase bumped it's Distributions compat to 0.25.3. So maybe the issue is already resolved by that?
Okay, I'm hopeful the problem will be resolved if TreeParzen bumps its Distributions compat to 0.25. It is still at 0.24.
I also highly recommend that the github action CompatHelper be installed for this repo so that such needed updates are flagged automatically. You put CompatHelper.yml file in your .github/workflows folder, like this one and setup the keys as explained here.
@kd-iqvia Can you bump the compat for Distributions and ping me if there is still an issue?
Hello @ablaom and @kd-iqvia. Thanks for the quick reply. While the issue is not fixed, I will follow @kd-iqvia suggestion and use an older version.
Sorry I misclicked the close button. :)
Thank you again!
Hi @irving-muller just wanted to let you know that the recently released TreeParzenv0.2.7
works with Julia v1.6.0
. and v1.6.2
by just ] add TreeParzen
.
There is a latest Julia 1.6.3 version from September 24th and I tested it in the meantime and while TPE works with it, there are some compilation issues with other dependencies so I'd suggest to stick to Julia 1.6.2 and give some time for other packages to get updated as it usually takes some time after new Julia releases.
Thanks to compatibility helper PR from @ablaom we will be also in position to monitor the compatibility issues more efficiently.
Unless, you'd like us to follow up more on this - let me know if you can consider this issue as closed.
Hello @kd-iqvia. Ok, thank you very much!!
Describe the bug I tried to install TreeParzen using pkg. However, TreeParzen cannot be precompiled. Please find bellow the log:
To Reproduce
] add TreeParzen
Expected behavior
TreeParzen is precompiled
Environment (please complete the following information):