IQVIA-ML / TreeParzen.jl

TreeParzen.jl, a pure Julia hyperparameter optimiser with MLJ integration
Other
35 stars 5 forks source link

Delayed operators #71

Closed yaxxie closed 3 years ago

yaxxie commented 3 years ago

Thank you for your contribution. You're a :star: already!

Before submitting this PR, please have a look at the below checklist so that we know more about your PR. Please also reference any relevant issues from the issues page if this PR is intended to address one of those.

What does this PR do?

Checklist

kainkad commented 3 years ago

@yaxxie thank you so much for this amazing PR to bring the transformations in. I'll double the spaceprint but it looks good as it is. I might just add few more test scenarios as the ones on the PR are currently showing transformations where left and right or 'a' and 'b' are HP functions whereas we have few use cases where the left operator would be a number but I can see it's implemented in delayed operators with the 'Real' dispatch so it should just work. I will sort out documentation in a separate PR with some visualisations for the users to show these transformations.

yaxxie commented 3 years ago

I'm happy to add the extra tests

yaxxie commented 3 years ago

a7c60025bdc20276ba2f9ff9d6f05a47037ad6cb adds a few quick and dirty scalar operation tests -- it doesn't check both left and right side of binary operators, which would be an issue if the operator was not registered for one of the other sides, but its also a super quick patch if it was. Let me know if you need anything else for this PR