Closed FatemehTahavori closed 1 year ago
@yaxxie could you please give an access to @BojieSheng, he is going to work on fixing this issue.
@FatemehTahavori Access isn't required, maintainers can merge PRs. But I don't have control to make those changes.
But regarding the PR, please don't merge as I have comments which I will make later
@FatemehTahavori I merged a CI change to include 1.7 and 1.8, please merge it into this branch
I know it is failing I will have a look later tonight
I know it is failing I will have a look later tonight
No worries thanks for the efforts!
I fixed the test but I would like to know what was wrong with previous commit
equal_vals = 0
for i in 21:100
equal_vals += trials[i].vals[:a] == trials[i].vals[:b] ? 1 : 0
end
equal_vals_percentage = equal_vals * 100 / length(21:100)
I fixed the test but I would like to know what was wrong with previous commit
equal_vals = 0 for i in 21:100 equal_vals += trials[i].vals[:a] == trials[i].vals[:b] ? 1 : 0 end equal_vals_percentage = equal_vals * 100 / length(21:100)
I tested this code many times (more than 500 times), have never got this error.
Whats the latest on this PR? It is a prerequisite to #90
I will close it as this PR https://github.com/IQVIA-ML/TreeParzen.jl/pull/90 has more comprehensive tests
Thank you for your contribution. You're a :star: already!
Before submitting this PR, please have a look at the below checklist so that we know more about your PR. Please also reference any relevant issues from the issues page if this PR is intended to address one of those.
What does this PR do?
Add a test case to reproduce the issue in “obs_memo” func from a higher level. For more details about this issue see here https://github.com/IQVIA-ML/TreeParzen.jl/issues/86.
{'a': 10, 'b': 1}
Checklist
julia --project -e 'using Pkg; Pkg.test()'
has been run locally and passes