Fixed nid bug - Githubissues

IQVIA-ML / TreeParzen.jl

TreeParzen.jl, a pure Julia hyperparameter optimiser with MLJ integration

Other

35 stars 5 forks source link

Fixed nid bug #90

Closed BojieSheng closed 1 year ago

BojieSheng commented 1 year ago

Thank you for your contribution. You're a :star: already!

Before submitting this PR, please have a look at the below checklist so that we know more about your PR. Please also reference any relevant issues from the issues page if this PR is intended to address one of those.

What does this PR do?

The issue relating “obs_memo” function was fixed and unit tests have been added from a higher level. For more details about this issue see here https://github.com/IQVIA-ML/TreeParzen.jl/issues/86.

Checklist

[x] Your code builds clean without any errors or warnings
[x] Unit tests have been added for core changes
[x] julia --project -e 'using Pkg; Pkg.test()' has been run locally and passes

BojieSheng commented 1 year ago

@yaxxie I would much appreciate if you can let me know whether you would like to review this PR.