extended tell! signature

IQVIA-ML / TreeParzen.jl

TreeParzen.jl, a pure Julia hyperparameter optimiser with MLJ integration

Other

35 stars 5 forks source link

extended tell! signature #94

Closed kainkad closed 1 year ago

kainkad commented 1 year ago

Thank you for your contribution. You're a :star: already!

Before submitting this PR, please have a look at the below checklist so that we know more about your PR. Please also reference any relevant issues from the issues page if this PR is intended to address one of those.

What does this PR do?

resolves #93

Checklist

[x] Your code builds clean without any errors or warnings
[x] julia --project -e 'using Pkg; Pkg.test()' has been run locally and passes

kainkad commented 1 year ago

@FatemehTahavori and @BojieSheng - could you please have a look and let me know if you can think of any reasons why we shouldn't extend the tell! signature to take Float32. This change resolves bug raised #93

BojieSheng commented 1 year ago

In Treeparzen, the struct Trial is defined as below: ''' mutable struct Trial hyperparams::Any vals::ValsDict loss::Float64 end ''' only change the tell function may not solve the issue.

kainkad commented 1 year ago

I'm closing this PR for now as the signature change may not be needed. I will keep this branch for now a it has an example with MLJXGBoostInterface.XGBoostClassifier mimicking the one raised in the issue #94 which works with the current signature handling Float64. Since the example brings a dependency not compatible with lower versions of Julia, I won't make it a part of the code base.