Open perellonieto opened 6 years ago
Looks like a bug, I'll investigate
Ok I think this was a python 2/3 change, should now be fixed. I also had to change the name of the plugin directory so that it doesn't conflict with the main one.
@tdiethe what is the change that should fix the problem? Is it n the last commit to the change of folders? Or is it some change in the main HyperStream? Maybe I have still the error because I am using Python2.7? If that is the case and it is complicated to solve we could move to Python3 as a workaround.
Change is in main hyperstream
On 1 Dec 2017, at 17:27, Miquel Perelló Nieto notifications@github.com<mailto:notifications@github.com> wrote:
@tdiethehttps://github.com/tdiethe what is the change that should fix the problem? Is it n the last commit to the change of folders? Or is it some change in the main HyperStream? Maybe I have still the error because I am using Python2.7? If that is the case and it is complicated to solve we could move to Python3 as a workaround.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/IRC-SPHERE/HyperStreamOnlineLearning/issues/9#issuecomment-348556323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABDyIFpdcT6xVh1qvzRsm89f0p2AjEPPks5s8DbxgaJpZM4QyhQe.
Thinking that the time has come to start dropping py2 support anyway:
http://www.python3statement.org/ https://github.com/numpy/numpy/blob/master/doc/neps/dropping-python2.7-proposal.rst
For some reason when running two consecutive tests that load the iris data in a stream an exception is raised:
First test issolated OK
Second test issolated OK
All the tests FAIL
This is because the zip creates a structure with two components (a,b) and not two values a, b.
However, the problem comes from above in line 281 as it is trying to compare two arrays old[key] and value[key] and the result is an array with 3 trues.
I am not sure why is this comparison being done. I assume that it is because the stream with the same name is called in sequence during the tests and HyperStream looks if the streams are the same. However, do we need to extend the comparison to arrays? Or is there some proper way to do this?