IRL2 / SubtleGame

A psychophysics game for interactive molecular dynamics
Other
1 stars 0 forks source link

The position of the box is likely sent wrong to the shared state #149

Closed jbarnoud closed 4 months ago

jbarnoud commented 6 months ago

When looking at a recording, the simulation box does not appear in front of the player.

https://github.com/IRL2/SubtleGame/assets/1382074/8acd84d9-7698-4d3a-95af-ef06155e4f21

This is likely due to the scene key not being correct when sent to the shared state.

To test this hypothesis:

While the player is manipulating the molecules, does Narupa iMD see the simulation box in front of the player? If they do, then this issue is invalid and the problem comes from the replay server. If the simulation box is not in front of the player, then the scene is indeed incorrect.

jbarnoud commented 6 months ago

I think the issue may be that the transform sent under the scene key does not account for the calibrated space.

rhoslynroebuck commented 6 months ago

Just tested this, yeah the box is not in the correct place

jbarnoud commented 6 months ago

Once this is fixed, I would be interested to know if there is a way to fix existing recordings.

Ragzouken commented 5 months ago

Very likely to be fixed by https://github.com/IRL2/SubtleGame/pull/171 but would be good to have confirmation.

As for fixing existing recordings: I believe in those that the box would only ever be translated/scaled, never rotated, so in theory it should be simple to determine the translation/scale that will match the hands to the interaction points. I think the scales are only ever .3 and .15 too.

rhoslynroebuck commented 4 months ago

Fixed in PR #171