IRL2 / nanover-rs

Other
0 stars 0 forks source link

Locks unlimited in time have undefined behaviour #216

Closed jbarnoud closed 1 month ago

jbarnoud commented 2 months ago

The issue is described in narupa-protocol.

The protocol assumes that locks all have a timeout; a request with a null timeout associated with a lock is interpreted as a request to remove the lock. However, the code would allow a lock without a timeout creating a scenario that cannot be reached.

jbarnoud commented 1 month ago

This got answered here: https://github.com/IRL2/nanover-protocol/issues/81#issuecomment-2095837761

Creating an unlimited lock is possible as an internal API but is not exposed by the protocol.