Update developer install to modern package toml

IRL2 / nanover-server-py

https://irl2.github.io/nanover-docs/#

Other

0 stars 1 forks source link

Update developer install to modern package toml #250

Closed Ragzouken closed 1 month ago

Ragzouken commented 1 month ago

re: https://github.com/pypa/pip/issues/11457

compile_proto now a standalone script instead of a setup.py subcommand
setup.py replaced with pyproject.toml
compile scripts now look for pyproject.toml instead of setup.py to determine which folders are packages
remove bld.bat in nanover-core conda package -- not clear why this is the only one with such a script

Ragzouken commented 1 month ago

Much of the way there but the package installation doesn't work properly (in conda only?)

Ragzouken commented 1 month ago

The compile scripts weren't correct, but now seem to be working, now only conda packaging tests are failing I think.

Ragzouken commented 1 month ago

Just need to fix mypy CI now..

Ragzouken commented 1 month ago

I noticed that some tests are failing, The error occurs in the test test_remove_service within the file python-libraries/nanover-essd/tests/test_essd_client_server.py. The assertion was checking that a ServiceHub instance was not in a set of ServiceHub instances, but it failed because it was found in the set.

@Ragzouken could you check before merging?

It's a recurring issue unrelated to this change.. it's irritatingly persistent https://github.com/IRL2/nanover-protocol/issues/154