search

IRMP-org / IRMP

Infrared Multi Protocol Decoder
GNU General Public License v3.0
267 stars 43 forks source link

Restore TIFR2 assignment in initIRTimerForSend #19

Closed yumkam closed 3 years ago

yumkam commented 3 years ago

I noticed dubiously commented code and tracked it back to commit 0cb1476fd9b85d486c4cb42dd9578656351331ad; it looks like accidentally commented out during refactoring. Beware: not even compile-tested, please check carefully if this line is really needed/etc (note that it was previously present in irsnd_init_and_store_timer/IRInitSendTimer, but not in irmp_init_timer/initIRReceiveTimer). Either way, as it is, it is confusing and broken.

ArminJo commented 3 years ago

Thank you very much for finding this error! 👍 🥇 I mention you in the readme and solved it with my commit, adding alinged comments in the same run.