IRMP-org / IRMP

Infrared Multi Protocol Decoder
GNU General Public License v3.0
267 stars 43 forks source link

Additional documentation for DigiSpark boards #54

Closed drechc closed 3 years ago

drechc commented 3 years ago

Bug Report

Board

IDE

IR-Protocol

Example to reproduce the issue

Version

Current behavior

None of the examples successfully compile using the "official" (but outdated) Digistump core. (Various errors due to different compiler versions, missing pin definitions, etc).

When using the ATtinyCore by SpenceKonde with the "Micronucleus/Digispark Pro" board and the "DigiSpark Pro" pin mapping, the functions in digitalWriteFast.h do not use the same pin numbers as the rest of the core.

Expected behavior

Documentation should include a reference to the newer and better DigiSpark core at: https://github.com/ArminJo/DigistumpArduino

It would also be helpful to note the "New Style" pin mapping must be selected when using the ATtinyCore and the "Micronucleus/Digispark Pro" board.

checklist:

We will start to close issues that do not follow these guidelines as it doesn't help the contributors who spend time trying to solve issues if the community ignores guidelines!

ArminJo commented 3 years ago

Thanks for the reporting! Fixed by modifying digitalWriteFast.h

drechc commented 3 years ago

That's a neat trick, I couldn't think of a clean way to to do it... Thanks for the fix!