IRNAS / irnas-east-software

East is a command line meta-tool, useful for creating, managing, and deploying Zephyr or nRF Connect SDK projects.
MIT License
10 stars 1 forks source link

Add update message to other commands #119

Closed klancarLuka closed 7 hours ago

klancarLuka commented 2 weeks ago

Context

As far as I've seen the only time the update text gets printed is when calling east clean

╭──────────────────────────────────────────────────────────────────────────────╮
│                                                                              │
│ New version of east is available!                                            │
│ Run pip install --upgrade east-tool to update.                               │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

It would greatly benefit the user experience if this message was printed with the use of other commands as well. It would be especially useful if the print would trigger when calling east --version or east --help, or other similar commands.

Required steps / Implementation details

Depending on the implementation details adding the version check before each command could cause the opposite effect on the user experience (spamming the user, minor work delays), so only add the print where you deem it right.

Definition of Done

MarkoSagadin commented 7 hours ago

@klancarLuka this is not an issue anymore I assume?

klancarLuka commented 7 hours ago

Not an issue, as discussed IRL :)