IRNAS / ppk2-api-python

Power Profiling Kit 2 unofficial python api.
http://irnas.eu
GNU General Public License v2.0
145 stars 37 forks source link

Fix: Multiprocessing unable to stop #16

Closed Solidedge closed 1 year ago

Solidedge commented 2 years ago

Not sure if this is the best way to fix this, but this fixed Issue #13. I assume this was the intention as the function below (get_data) isn't called anywhere else. Someone more fluent in python should confirm this.

wlgrd commented 2 years ago

Nice one. Just to make your PR a bit cleaner, please fixup the first commit through a rebase. "Cleaner fix" doesn't say much without context from the last commit. Just do for example

git fetch
git rebase -i origin/master
<set second commit to fixup (or f)>
<close file to continue rebase>
git push --force