search

IRNAS / ppk2-api-python

Power Profiling Kit 2 unofficial python api.
http://irnas.eu
GNU General Public License v2.0
145 stars 37 forks source link

Enhancement of PPK_API object destructor to reset the PPK2 before closing the serial connection #40

Closed rgroh1996 closed 9 months ago

rgroh1996 commented 9 months ago

The PPK2 was not reset when the object was deleted. The PPK2 is reset with the PPK2 RESET command. This allows a new connection to be established immediately.

wlgrd commented 9 months ago

Nice addition. Please update your commit title to adhere to github's max length. Suggestion, do git commit --amend, and change to 

send reset command in destructor

The PPK2 was not reset when the object was deleted.
The PPK2 is reset with the PPK2 RESET command.
This allows a new connection to be established immediately.

then do a git push --force after saving the new commit

juhhov commented 1 day ago

Could this be included into release? @wlgrd @NejcKle