Closed LauraEhlis closed 4 years ago
While clicking in the "time-in" or "time-out" edit field the user is able to change the start and stop times. The hours, minutes, seconds or frames can be separately controlled.
The corresponding number values are marked and the cursor is placed on exactly the number where the user clicked. Using the keyboard the start and stop times can be changed. It's also possible to jump between hours, minutes, seconds and frames using the arrows.
@LauraEhlis One question: initially the subtitles are in an ascending order based on the begin time. If you change the begin time: how does this affect the order of the subtitles that are currently displayed? If subs should be re-ordered: when does the re-ordering take place? After the user leaves the edit field of the time value?
@LauraEhlis Another question: how does the state of video position change during/after time value editing
@LauraEhlis Another issue is when a user sets the begin time to value that is equal or later than the end time. Either an error message is shown or it is not possible to extend the end time beyond the begin time or vice versa to change the end time so that it is earlier than the begin time...
@LauraEhlis One question: initially the subtitles are in an ascending order based on the begin time. If you change the begin time: how does this affect the order of the subtitles that are currently displayed? If subs should be re-ordered: when does the re-ordering take place? After the user leaves the edit field of the time value?
If the user changes the start or stop time the order of the subtitles that are currently displayed doesn't change. But there is a "Refresh-Icon". While clicking on this icon the subtitles are re-ordered. The focus stays on the subtitle which was last edited.
@LauraEhlis Another issue is when a user sets the begin time to value that is equal or later than the end time. Either an error message is shown or it is not possible to extend the end time beyond the begin time or vice versa to change the end time so that it is earlier than the begin time...
Yes, it shouldn't be possible to extend the end time beyond the begin time or vice versa and there should also be an error message.
@LauraEhlis Another issue is when a user sets the begin time to value that is equal or later than the end time. Either an error message is shown or it is not possible to extend the end time beyond the begin time or vice versa to change the end time so that it is earlier than the begin time...
Yes, it shouldn't be possible to extend the end time beyond the begin time or vice versa and there should also be an error message.
Should the times be automatically changed to guarantee there is no duration less than 0s? And if so should there be another error message independent of the warning for minimum time?
If we have for example a subtitle block with begin=2s
and with end=4s
. The question is what happens if the user wants to change the begin time to 4s
or to 4.1s
. As I understand the proposed solution the begin time will not go beyond 3.960s
(i.e. will be automatically corrected to this value).
Of course, this value does also not lead to a desirable outcome (with a duration of 40 ms). It is also the question if an error message should be shown (as @lauraEhlis proposed). If the value is corrected it is afterwards (at least technically) compliant.
Possibly it is better to let the user change the value as desired and show an error message? I can imagine that a user might want to first change the begin time (e.g. to 4s
in the example) and then afterwards adjust the end time (e.g. to 6s
).
If we have for example a subtitle block with
begin=2s
and withend=4s
. The question is what happens if the user wants to change the begin time to4s
or to4.1s
. As I understand the proposed solution the begin time will not go beyond3.960s
(i.e. will be automatically corrected to this value).Of course, this value does also not lead to a desirable outcome (with a duration of 40 ms). It is also the question if an error message should be shown (as @LauraEhlis proposed). If the value is corrected it is afterwards (at least technically) compliant.
Possibly it is better to let the user change the value as desired and show an error message? I can imagine that a user might want to first change the begin time (e.g. to
4s
in the example) and then afterwards adjust the end time (e.g. to6s
).
Resolved by 2233b7e, 43416a8 and 9c5699f
The user can individually change the start and stop time of every subtitle.