search

IRT-Open-Source / scf

Subtitling Conversion Framework
Apache License 2.0
52 stars 18 forks source link

STLXML2EBU-TT: NEEDLESS ALIGNMENT tt:span #1

Closed andreastai closed 9 years ago

andreastai commented 9 years ago

The style creation for inline elements (tt:span) includes the style attribute tts:textAlign.

The attribute tts:textAlign applies only to tt:p elements but not to tt:span elements. Therefore no distinction of text alignment has to be made creating style references for a tt:span. Consequently styles that apply only to tt:span do not need any information about text alignment.

Although the current code do not result in incorrect rendering and still produces conformant XML it needs to be refactored because it is misleading.

andreastai commented 9 years ago

Will be fixed in next release.

ghost commented 9 years ago

Fixed in 15f4fe7581a14aac201434ceff849390890cf4d