IRT-Open-Source / scf

Subtitling Conversion Framework
Apache License 2.0
52 stars 18 forks source link

Only output the styles that are actually used #10

Closed nigelmegitt closed 8 years ago

nigelmegitt commented 8 years ago

The current STLXML2EBU-TT stylesheet always outputs the whole set of styles for all the different foreground and background colour combinations even if only a subset of those styles are used. Those are then copied across by EBU-TT2EBU-TT-D and are therefore preserved. It would be a good improvement to insert only those styles into the EBU-TT that are actually used.

andreastai commented 8 years ago

This is indeed an issue we noted and we implemented an XSLT some time ago that solve this issue but it has not been pushed and merged yet. It will be there in the next release.

nigelmegitt commented 8 years ago

Great, I look forward to that. If you could make it available sooner that would be extremely useful.

andreastai commented 8 years ago

The module is now published https://github.com/IRT-Open-Source/scf/tree/master/modules/TT-Helper/TT-Filter-Styles-No-References

nigelmegitt commented 8 years ago

Thanks - works great!