search

IRT-Open-Source / scf

Subtitling Conversion Framework
Apache License 2.0
52 stars 18 forks source link

Helper module to extract the ebuttm:documentStartOfProgramme value in seconds #15

Closed nigelmegitt closed 7 years ago

nigelmegitt commented 8 years ago

Probably not the tidiest possible XSL but functional. Output may be passed into EBU-TT2EBU-TT-D.xslt for conversion from smpte timebase to media timebase using the ebuttm:documentStartOfProgramme value.

andreastai commented 8 years ago

The EBU-TT2EBU-TTD XSLT already has already a offsetInFrames parameter also could take the value of the ebuttm:documentStartOfProgramme element. This option was by accident not document but is now present in the requirements document and the readme. Apologies for that.

spoeschel commented 7 years ago

Sorry for the quite long delay!

We discussed the PR and decided that we instead want to have the functionality (as described in #12) in the main code here. The reason is that this is more user-friendly and also avoids possible problems, as using/connecting two different XSLTs for (in the end) a single step is error-prone and would require further care by the user. This can better be addressed by integrating the functionality in the respecting modules themselves. Sorry!