IRT-Open-Source / scf

Subtitling Conversion Framework
Apache License 2.0
52 stars 18 forks source link

STL2SLTXML: Mapping of TTI blocks containing comments #27

Open pthopesch opened 7 years ago

pthopesch commented 7 years ago

In the current scf verison 0.2.8, TTI blocks from an STL file that contain comments are ignored when transforming from STL to STLXML. These comments should be mapped as well in order to achieve a "better" XML representation of the STL file.

CF set to 00h --> TTI Block contains subtitle data CF set to 01h --> TTI Block contains comments

The mapping of the text field (TF) of a comment should be handled is the same way that a normal subtitle is.

The description of the requirement no. 214 "Comment Flag mapping" should be updated accordingly.

braincoded commented 7 years ago

+1 A very good point!

pthopesch commented 7 years ago

Comments should be mapped from STLXML to EBU-TT according to EBU-TT Part 2:

"The text content of a comment TTI block in an STL file may be placed into an ebuttExt:comment element. The ebuttExt:comment element must itself be a child element of a tt:metadata element, which must be the first child element of the containing tt:p element. The TTI block containing the comment may be associated with subtitle text in another TTI block (by having matching TCI and TCO values or SN value), or may be independently timed, as below: [...]" Page 35

nigelmegitt commented 7 years ago

I think we will probably be deprecating ebuttExt and will just make this metadata in ebuttm, to be confirmed.