IRT-Open-Source / scf

Subtitling Conversion Framework
Apache License 2.0
52 stars 18 forks source link

STL2STLXML: add option to discard UDA field + User Data TTI blocks #44

Closed basicmaster closed 6 years ago

basicmaster commented 7 years ago

There should be an option to discard the user data that can be contained within a TTI block.

spoeschel commented 6 years ago

As this may already affect the workflow STL -> STLXML -> STL, it makes more sense to add this option to STL2STLXML.

spoeschel commented 6 years ago

And to also discard the content of the GSI block's UDA field.

braincoded commented 6 years ago

Please handle the two cases separately, i. e. one should be able to disable them individually. While a) user data within the TTI block can cause problems in some subtitle editors, when user data in the TTI block after a STL -> STLXML -> manipulation -> STL conversion is given priority over the regular TTI data and thus one should be able to discard it, b) the GSI/UDA should still be usable and not discarded simultaneously. Thanks!

spoeschel commented 6 years ago

We will indeed handle the two cases separately, for the reason you mentioned, to be flexible in discarding/clearing this user data.