search

IRT-Open-Source / scf

Subtitling Conversion Framework
Apache License 2.0
52 stars 18 forks source link

STL2STLXML: specific chars with diacritical chars not mapped #54

Closed spoeschel closed 4 years ago

spoeschel commented 5 years ago

A few characters with diacritical characters are not mapped from STL to STLXML. This includes e.g.:

J́
j́
J̃
L̃
M̃
R̃
j̃
l̃
m̃
r̃
E̊
e̊

This is caused by the following conditional check: https://github.com/IRT-Open-Source/scf/blob/da049f4ee0e40e4ffcdf1b775d27dd0cd4b65a16/modules/STL2STLXML/stl2stlxml.py#L182

spoeschel commented 5 years ago

This only affects characters for which no pre-combined Unicode character exists. So characters like e.g. äöüß are NOT affected.