WebODM migration

[jreyesr]

This issue is intended to track all code changes required, should the decision be made to switch AgroSmart to use WebODM as a processing provider.

Backend

core/models.py

• [x] L195, GET http://container-nodeodm:3000/task/uuid/info
• [x] L406, POST http://container-nodeodm:3000/task/new/init
• [x] L418, POST http://container-nodeodm:3000/task/remove

core/views.py

• [x] L247, POST http://container-nodeodm:3000/task/new/upload/uuid
• [x] L255, POST http://container-nodeodm:3000/task/new/commit/uuid

Test files

Test files are intentionally not listed here. See https://github.com/IS-AgroSmart/AgroSmart-Web/issues/104#issuecomment-768726324 below for the proposed way of dealing with tests.

Frontend

FlightDetails.vue

• [x] L71, GET /nodeodm/task/uuid/output
• [x] L81, GET /nodeodm/task/uuid/info
• [x] L120, POST /nodeodm/task/cancel

[jreyesr]

Planned migration procedure:

• Backend: Unify base URL of NodeODM server, send auth information
  • [x] Locate all places where any request to http://container-nodeodm:3000/... is made (see above comment for list).
  • [x] Refactor the base URL to be pointable to https://spark1.webodm.net:443 or to the current, local URL (http://container-nodeodm:3000/...). Ideally move the URL declaration to settings.py, or some other central place, and place the actual declaration on settings.ini so it can be edited more easily and without changing the source code. Call the variable NODEODM_SERVER_URL
  • [x] Edit all requests to also send a secret token as a query param (?token=whatever), which shall also come from settings.py and settings.ini, just as NODEODM_SERVER_URL.
  • [ ] On the webhook, download a ZIP of the results and decompress it to /flights/uuid. That way, all results are there for the magic Result Post-Processing code.
• Frontend: No changes required if server config is altered to proxy /nodeodm to Django. See next bullet point.
• Servers: Do ~Nginx~ Traefik magic dance so that frontend still sees same data at /nodeodm/whatever
  • [x] Edit ~Nginx~ Traefik config to redirect /nodeodm to Django too. Remove NodeODM container from Traefik config altogether.
  • [x] Add new URL on Django routes to handle /nodeodm
  • [x] URL handler must handle routes GET nodeodm/task/<uuid>/output, GET nodeodm/task/<uuid>/info and POST nodeodm/task/cancel

[jreyesr]

~Test handling is a pending issue.~ Tests are confirmed working. The Pytest runner sets the NODEODM_SERVER_URL envvar to http://container-nodeodm:3000, and all mocks work as expected.

If the approach outlined in https://github.com/IS-AgroSmart/AgroSmart-Web/issues/104#issuecomment-768721265 is taken, it should be easy to keep tests working by overriding the settings.NODEODM_SERVER_URL variable. If it's set back to http://container-nodeodm:3000, tests should still create their mocks for the correct URLs and therefore keep working as expected.

[jreyesr]

~There is still the issue of receiving webhooks. WebODM Lightning does not support calling a webhook after processing is complete. Therefore, there should be some way of simulating the webhook. WIP in https://github.com/IS-AgroSmart/webhook_adapter~

This problem is already solved and merged