PNG artifact - Githubissues

IS-AgroSmart / AgroSmart-Web

1 stars 1 forks source link

PNG artifact #31

Closed jreyesr closed 4 years ago

jreyesr commented 4 years ago

Per #9, ODM doesn't generate a PNG orthomosaic anymore. This alters a couple of functions:

There is no way to download a PNG artifact, only GeoTIFF. This was solved by simply deleting the PNG download button, both on web and mobile
The "Preview Orthomosaic" option on mobile is broken, since it used to download and show the PNG image.

Screenshot

jreyesr commented 4 years ago

Proposed solution:

[x] Extend "Processing complete" webhook to create PNG orthomosaic
[x] Add method get_png_ortho_path to Flight model, must return /odm_orthophoto/odm_orthophoto.png
[x] Add method try_create_png_ortho to Flight model
[x] Create a full-res PNG, reuse the thumbnail creation code but ignore the 4 lines that resize the image and mask
[x] Save full-res PNG on odm_orthophoto folder, call it odm_orthomosaic.png
[x] Add unit tests to get_png_ortho_path method

Will probably require some refactoring. Relevant code is on models.py, on try_create_thumbnail. https://github.com/IS-AgroSmart/AgroSmart-Web/blob/e30e166b90d6c9d5a7c15b29175b0347cd0c7f53/core/models.py#L208-L240