representation project evaluation

[lemkis]

Evaluation

Exceptionally (because it is the first project) you can correct errors listed below to retrieve lost points. Deadline Friday 12.04.24. You have only one chance to correct your project. Your next PR is the last one. If you correct these errors and you do not introduce new ones you get max number of points for this project.

• line 43 std::_Gcd use std::gcd (never use internals) Missing includes e.g. #include <numeric> - code does not compile in my case you need to include the following #include <concepts> #include <vector> #include <string> #include <print> #include <cmath> #include <numeric> #include <charconv> #include <ranges> #include <algorithm> check if works for you as well. -8pts
• Polish letters are not rendering correctly / use English descriptions of functions (you can use Polish in README.md) -1pt
• to long lines e.g. see line 240 - Please use width max 80
• your pow function should return integers not floating points -1pt
• mixing Polish and English e.g. line 257 (use English only when writing code) -1pt
• repetition of code (each block of 4 in function representation_tests() is of similar form us a helper function - in particular it solves the problem of magic numbers) -2pt
• lines 45-47 . This operation reduces a fraction so it should be a member method of a fraction called void reduce() -1pt
• line 146 - correct name rest to remainder -1pt
• your tests does not explain to user what base is used during conversions... -1pt

• Please replace formatters so that they work with clang as well:

  template <std::integral I>
  struct std::formatter<representation::fraction<I>> {
  
  template <typename FormatParseContext>
  constexpr auto parse(FormatParseContext& ctx) { return ctx.begin(); }
  
  template <typename FormatContext>
  auto format(const representation::fraction<I>& f,
      FormatContext& ctx) const {
      return std::format_to(ctx.out(), "{}/{}", f.numerator, f.denominator);
  }
  };

  and

  template <std::uint8_t base>
  struct std::formatter<representation::expansion<base>> {
  
  template <typename FormatParseContext>
  constexpr auto parse(FormatParseContext& ctx) { return ctx.begin(); }
  
  template <typename ParseContext>
  auto format(const representation::expansion<base>& exp,
      ParseContext& ctx) const {
      return std::format_to(
          ctx.out(), "{}.{}({})", exp.whole, exp.fractial, exp.period);
  }
  };

[lemkis]

Moreover, add the tests of following form:

expand(dexpand(...)) = identity
dexpand(expand(...)) = identity

to stress that dexpand and expand mutual inverses

[lemkis]

You corrected all problems - that is why you receive maximal number of points for this project,that is 9pts