Since I cannot post these on the forum, I shall do so here, in hope that either Kalcor or YSF fixes them. Feel free to post your own issues you have found in the code.
AddSimpleModel & co. uses calloc to create CModelInfo, but it doesn't seem to free the memory if the creation fails (file not found). [not fixable without rewriting the code].
The same code returns 0 on failure (bad file), -1 on allocation fail, or any non-negative value for success. 0 is therefore also returned for the first model. [not fixable without changing the code and API]
Again in the same place, CArtList's size increases linearly instead of geometrically. The list has dynamic size and is reallocated every time a new model info is inserted, but the size is increased by 1 every time, resulting in 10000 calls to realloc for 10000 model insertions. The standard method is to double the size each time. [fixable by hooking the resize function]
Since I cannot post these on the forum, I shall do so here, in hope that either Kalcor or YSF fixes them. Feel free to post your own issues you have found in the code.