search

ISA-tools / ISATab-Viewer

An ISA-Tab web viewing library written in Javascript.
MIT License
3 stars 2 forks source link

Add capability to create a repository from multiple files #5

Open eamonnmag opened 10 years ago

eamonnmag commented 10 years ago

Either as gists or files on the same server.

sneumann commented 3 years ago

Hi, maybe this issue is indeed what I am currently looking for. Or this is already implemented and can be closed :-) The screenshot in the README.md here already shows a list of two studies (BII-S-1 and BII-S-2) on the left-hand side. I tried that in https://ipb-halle.github.io/ISATab-DataSets/index.html and during page load one briefly sees MTBLS679 appearing, before it is overwritten by MTBLS1968. Ideally I only messed up how to add the studies in https://github.com/ipb-halle/ISATab-DataSets/blob/main/index.html#L44 If I check the DOM in the browser developer tools, I only see one entry:

<li id="list--668175316" onclick="ISATabViewer.rendering.render_study('MTBLS1968', '-668175316')" class="active">MTBLS1968</li>

so it looks like MTBLS1968 was overwriting the previous MTBLS679. So, did I get things wrong and a fix is possible in my ISATabViewer.rendering.render_isatab_from_file(), or is there an issue in https://github.com/ISA-tools/ISATab-Viewer/blob/master/isaviewer_assets/js/ISATabViewer.js#L47 ? Yours, Steffen

sneumann commented 3 years ago

It helps to not empty the study list upon every call to render_isatab_from_file() https://github.com/ISA-tools/ISATab-Viewer/blob/master/isaviewer_assets/js/ISATabViewer.js#L578 to get a full list of investigations in the navigation on the left. Investigations can be selected, but the sample information is always the one from the Investigation loaded last. Yours, Steffen