search

ISA-tools / isa-api

ISA tools API
https://isa-tools.org
Other
40 stars 37 forks source link

comment_schema.json is different depending on the source #483

Open rabuono opened 1 year ago

rabuono commented 1 year ago

The comment_schema.json in the repo at: isatools/resources/schemas/isa_model_version_1_0_schemas/core/comment_schema.json

Is different from the one at the read the docs: https://isa-specs.readthedocs.io/en/latest/isajson.html#comment-schema-json

The "@id": { "type": "string", "format": "uri" }, property is missing in the GitHub version.

Was the @id for comments removed?

vdkkia commented 1 year ago

I don't see any difference here.

patrick-koenig commented 1 year ago

The "@id" property in "comments_schema.json" was removed by a commit of @proccaserra titled "addressing merge issues" on Feb 20, 2022: 9a463a3020ffb03de2a6951f26217bada87d1d26

image

Maybe this was an unintentional deletion?

@proccaserra Can you please comment or clarify on this?

proccaserra commented 1 year ago

@rabuono @patrick-koenig this is an error (ie unintentional delete). thank you for reporting. fixing asap

rabuono commented 1 year ago

Thank you for checking it!