ISA-tools / isa-api

ISA tools API
https://isa-tools.org
Other
40 stars 37 forks source link

0.13.0 installation error #487

Closed jundahuang9123 closed 1 year ago

jundahuang9123 commented 1 year ago

When pulled from master branch and install the 0.13.0 version. I encounter the following issue:

(isa) (venv) PS D:\CMBI_work\Projects\isa-api> python setup.py install D:\CMBI_work\Projects\isa-api\venv\lib\site-packages\setuptools\dist.py:484: UserWarning: Normalizing '0.13.0-rc.2' to '0.13.0rc2' warnings.warn(tmpl.format(**locals())) running install running bdist_egg running egg_info writing isatools.egg-info\PKG-INFO writing dependency_links to isatools.egg-info\dependency_links.txt writing requirements to isatools.egg-info\requires.txt writing top-level names to isatools.egg-info\top_level.txt error: package directory 'isatools\errors' does not exist

When I look into the repository I indeed cannot find the isatools.errors directory. Simply remove the line 23 of setup.py, I could finish the installation. However, when using the package, there are following errors:

Traceback (most recent call last): File "D:\CMBI_work\Projects\TWOCdemonstrator\tools\Su_2020_prepare_ISA_metadata\isa-to-rdfs.py", line 10, in from isatools import isatab File "D:\CMBI_work\Projects\isa-api\venv\lib\site-packages\isatools-0.13.0rc2-py3.10.egg\isatools__init__.py", line 20, in from isatools.convert import ( File "D:\CMBI_work\Projects\isa-api\venv\lib\site-packages\isatools-0.13.0rc2-py3.10.egg\isatools\convert\isatab2cedar.py", line 14, in from isatools.io import isatab_parser File "D:\CMBI_work\Projects\isa-api\venv\lib\site-packages\isatools-0.13.0rc2-py3.10.egg\isatools\io\isatab_parser.py", line 38, in from isatools import isatab File "D:\CMBI_work\Projects\isa-api\venv\lib\site-packages\isatools-0.13.0rc2-py3.10.egg\isatools\isatab__init__.py", line 1, in from isatools.isatab.dump import ( ModuleNotFoundError: No module named 'isatools.isatab.dump'

bedroesb commented 1 year ago

@jundahuang9123 I encountered the same issues, and solved the first one in the same way. The second one I was also not able to solve. @terazus do you have plans on finishing off version 13 and fixing the isatools.isatab.dump problem?

jundahuang9123 commented 1 year ago

@bedroesb, the second problem @terazus has pointed out that I have the virtual environment installed at a different directory from my work directory.

terazus commented 1 year ago

Hello, release 0.14.0 is on its way. The code on master has been updated and should fix your problem. To install from source: 1 - Clone the isa repo somewhere and note its path 2 - Create a new project 3 - cd in that project, create and enable a new venv 4 - Install ISA from local source with pip install -e path/to/isa

bedroesb commented 1 year ago

it is maybe worthed calling it v1.0.0 đŸ˜‰