search

ISA-tools / isa-api

ISA tools API
https://isa-tools.org
Other
40 stars 38 forks source link

Fix rule and check. #524

Closed ptth222 closed 6 months ago

ptth222 commented 8 months ago

Before this change the term_source_refs would be a single string like 'OBI' when it should have remained a list like ['OBI', 'NEWT']. The check_ontology_sources function returns a list, but for some reason the execute method in the Rule class was only taking the first value from the list instead of the whole list. I changed it to take the whole list.

This list was then used in the check_ontology_fields function, but the check that uses it was nested inside another. I believe this was in error, so I made the check independent.

terazus commented 8 months ago

Same comment as PR #526 : image

terazus commented 6 months ago

Closing: dupe of #548