search

ISA-tools / isa-api

ISA tools API
https://isa-tools.org
Other
40 stars 38 forks source link

Changed Tab and JSON validate #525

Closed ptth222 closed 6 months ago

ptth222 commented 8 months ago

Normalized the log_level between the Tab and JSON validate functions, so they operate the same way.

Previously, there was no way to disable or silence logging in the JSON validate, and in the Tab validate there was no way to actually change the level. I changed it so both functions do the same thing in regards to log_level.

terazus commented 8 months ago

I believe this build is failing because isatools/isatab/validate/core.py is missing an import statment. using the "or" sign in type annotations represented by "|" at line 173 here (https://github.com/ISA-tools/isa-api/pull/525/files#diff-00a4fb46a1d97588f77a950623b8349adc2beb808d7f50294a57f926a8263eceR173) require from __future__ import annotations

ptth222 commented 8 months ago

That could definitely be part of the issue. I work solely in Python 3.10, so I'm used to certain things being built in. These are all based on the develop branch as well, does the develop branch pass as is? One of these I looked into seemed to be failing, but it didn't have anything to do with the change I made.

terazus commented 8 months ago

That could definitely be part of the issue. I work solely in Python 3.10, so I'm used to certain things being built in. These are all based on the develop branch as well, does the develop branch pass as is? One of these I looked into seemed to be failing, but it didn't have anything to do with the change I made.

Yes, the requirement is for python versions anterior to 3.10 Develop seems to be stable and to pass into master: https://github.com/ISA-tools/isa-api/pull/505 However the build is a bit old and since then there has been changes to the OLS API. This is creating failure of a unit test (as mentionned in your other PR) that needs to be redesigned.

ptth222 commented 6 months ago

Incorporated in #551.