search

ISA-tools / isa-api

ISA tools API
https://isa-tools.org
Other
40 stars 37 forks source link

Rename i_df and investigation_df. #529

Closed ptth222 closed 3 months ago

ptth222 commented 5 months ago

i_df and investigation_df are not a DataFrame as indicated in parameter typing or as the name would suggest. It's actually a dictionary of DataFrames and lists of DataFrames. I have renamed them to reflect this.

ptth222 commented 4 months ago

Interesting. I wouldn't have expected this one to break anything since it just renames variables/parameters. I am looking into the testing now to try and understand how it all works to try and make changes to them so some of these PRs will pass.

ptth222 commented 4 months ago

That's strange. I don't see @terazus comments, but I got an email about it. I think you are right. I will look through the tests and try to find the renaming changes.

ptth222 commented 4 months ago

I did not mean to trigger a rerun on this when I rebased it. I am working on looking at the broken tests now.

coveralls commented 4 months ago

Coverage Status

coverage: 81.298% (-0.001%) from 81.299% when pulling 33dae30ee40d80676e6b24d4be8b86b39f10fd4b on ptth222:tab-validate-idf-rename into e5f6fd2a0f17e22fd02027fe01bd250683beff71 on ISA-tools:issue-511.

terazus commented 4 months ago

I did not mean to trigger a rerun on this when I rebased it. I am working on looking at the broken tests now.

You can mark PR as draft if you are not ready yet.

ptth222 commented 4 months ago

@terazus It is ready now. It initially ran when I did the rebase because the PR was already here and I think it was previously approved. The last commit I made triggered another rerun, but that is good to go.