ISA-tools / isa-specs

ISA Model and Serialization Specifications
http://isa-specs.readthedocs.io
5 stars 6 forks source link

Inconsistency in STUDY PROTOCOLS section #14

Open Hannah-Doerpholz opened 1 year ago

Hannah-Doerpholz commented 1 year ago

I notices while reading your specification that in the section STUDY PROTOCOLS the field "Study Protocol Parameters Name" and its two ontology field "Term Source REF" and "Term Accession Number" are used. However, while in your specification (and here: https://github.com/ISA-tools/isa-specs/blob/master/source/_static/isatab/study_protocols.csv) those fields are described as follows:

Study Protocol Parameters Term Accession Number Study Protocol Parameters Term Source REF

in your own examples (https://github.com/ISA-tools/isa-specs/blob/master/source/_static/isatab/i_investigation.txt and https://github.com/ISA-tools/isa-specs/blob/master/source/_static/isatab/i_gilbert.txt) it is different:

Study Protocol Parameters Name Term Accession Number Study Protocol Parameters Name Term Source REF

Personally, I find it more intuitive to add "Name" like in the examples, since it more accurately describes that the ontology fields belong to the "Study Protocol Parameters Name". Which of the two versions should be used in new files?