search

ISA-tools / mzml2isa-galaxy

mzml2isa for galaxy
6 stars 5 forks source link

Makes explicit mention to TAR support #5

Closed pcm32 closed 1 year ago

pcm32 commented 7 years ago

Only to signal that, down the line, full_parse supports on this position both Zip and TAR files. Didn't want to change the argument name to avoid API changes, but you might want to consider that for a backwards incompatible release in the future.

pcm32 commented 7 years ago

Please don't merge yet! Will add part to the mzml2isa.xml for Galaxy as well.

pcm32 commented 7 years ago

I still need to add the changes to the test part of the galaxy wrapper...

pcm32 commented 7 years ago

@Tomnl @althonos do you have a way of retrieving the log produced with planemo within the travis job? to see what is the offending part, fix it and merge this. Thanks!

Tomnl commented 7 years ago

not sure... you could simply just print out on the terminal?

Or you could upload artifacts to Amazon aws.... or perhaps with Dropbox

RJMW commented 7 years ago

You could use --test_output_text and print the output of the text file to the terminal.

pcm32 commented 7 years ago

@RJMW can you reopen the pull request (maybe you thought that this was an issue by mistake), so that this can be merged eventually. Or is it that you don't want the functionality.

RJMW commented 7 years ago

Sorry!

pcm32 commented 7 years ago

Thanks Ralf! No worries!

Tomnl commented 1 year ago

Closing this now as it is resolved in the latest release