search

ISAAKiel / oxcAAR

R Package - Interaction with Oxcal
GNU General Public License v2.0
21 stars 4 forks source link

Ggplot #35

Closed MartinHinz closed 3 years ago

MartinHinz commented 3 years ago

Added ggplot output functionality to the plots. This is the last open issue for milestone oxcAAR 1.1 Flora, so it might be worthwhile checking it in more detail

MartinHinz commented 3 years ago

Thank you for your very swift and detailed review! I see that there is still quite some room for improvement and I will correct the pull request accordingly before merging. Might be that I will ask you again for review this and the final release, if you are willing to do so!

MartinHinz commented 3 years ago

updated the PR. Would you, @nevrome, be probably so kind as rechecking, resolving and advising me on the still open points. Much appreciated!

MartinHinz commented 3 years ago

Also, forgot to merge master back in. Doing this in this minute and push when checked. Sorry!

nevrome commented 3 years ago

I think this is good to go :+1:

MartinHinz commented 3 years ago

Thank you so much! Merging now.